-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/improve mapping inference additional information #1070
Feat/improve mapping inference additional information #1070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggested values (score, annotation) should be copied anyway, it is easier to adjust them rather than copy/paste them. Btw when the relation is equal, most often we want to keep the score and annotation.
…of github.com:intuitem/ciso-assistant-community into feat/improve-mapping-inference-additional-information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We cannot automatically transfer score and observation during mapping (in case of different score scale and contextual observation). However, we should have these informations in the requirement, to let the user choose if he wants to copy paste them.
Example: