Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve mapping inference additional information #1070

Merged

Conversation

Mohamed-Hacene
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene commented Nov 21, 2024

We cannot automatically transfer score and observation during mapping (in case of different score scale and contextual observation). However, we should have these informations in the requirement, to let the user choose if he wants to copy paste them.
Example:
image

@Mohamed-Hacene Mohamed-Hacene requested review from nas-tabchiche, ab-smith and eric-intuitem and removed request for nas-tabchiche November 21, 2024 10:29
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested values (score, annotation) should be copied anyway, it is easier to adjust them rather than copy/paste them. Btw when the relation is equal, most often we want to keep the score and annotation.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 1293b5a into main Nov 27, 2024
20 checks passed
@eric-intuitem eric-intuitem deleted the feat/improve-mapping-inference-additional-information branch November 27, 2024 22:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants