Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/improve functional tests reliability #1129

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

These were useful in the times when we did not have `safeTranslate`.
Now they are just a hindrance preventing us from using the word
'undefined' in the frontend.
@nas-tabchiche nas-tabchiche force-pushed the ci/improve-functional-tests-reliability branch from efdad37 to 4062d25 Compare December 4, 2024 16:49
These have not been set in the DOC POL library, causing errors during
functional tests.
@nas-tabchiche nas-tabchiche force-pushed the ci/improve-functional-tests-reliability branch from 4062d25 to 378a10b Compare December 4, 2024 17:15
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 1a20bac into main Dec 4, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@Mohamed-Hacene Mohamed-Hacene deleted the ci/improve-functional-tests-reliability branch December 5, 2024 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants