Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make email comparison for SAML case insensitive #1173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fastlorenzo
Copy link
Contributor

Email comparison when doing SSO with SAML is currently case sensitive.
However, email addresses should be treated as case insensitive.

This PR makes sure that:

  1. Email address of each user is saved as lowercase in the database
  2. Email address received from IDP when doing SSO is converted to lowercase prior to comparison

@eric-intuitem
Copy link
Collaborator

eric-intuitem commented Dec 11, 2024

LGTM, but we need to adapt functional tests. @nas-tabchiche ?

@ab-smith
Copy link
Contributor

we will merge it after the Ebios RM sprint and fix the test on our side before releasing

@fastlorenzo
Copy link
Contributor Author

we will merge it after the Ebios RM sprint and fix the test on our side before releasing

Thanks, no worries, now that we know the current behavior we've fixed it in the IDP by forcing lowercase email conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants