add non-root user to frontend and backend containers #1228
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove huey further
eric-intuitem
force-pushed
the
improve/non-root-containers
branch
from
c05fbc5 to
00626b8
Compare
|
I think keeping same UIDs (and names like "app") for backend and frontend images are fine, and more simple to maintain. Also, chown is not needed to avoid binaries/code manipulation from app user, the application can be built as root but executable as non-root user. But you can add chown to app grp/user for app storage folders like db |
Following advice from Nathanael-Mtd
tentative fix for broken startup test
nas-tabchiche
approved these changes
Dec 24, 2024
nas-tabchiche
force-pushed
the
improve/non-root-containers
branch
from
bf76a71 to
ebd7c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove huey further,
should fix #1219