Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 197 show an error message to the user when he tries to create an object with the same name as another object in the same scope #138

Conversation

Mohamed-Hacene
Copy link
Collaborator

No description provided.

Mohamed-Hacene and others added 2 commits March 12, 2024 11:07
Missing test of uniqueness for threats
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are missing fields_to_check, which is not implicit anymore. I have added one for Threat, but there are others to consider.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…n-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
…n-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
@eric-intuitem eric-intuitem merged commit db84833 into main Mar 13, 2024
12 checks passed
@eric-intuitem eric-intuitem deleted the CA-197-Show-an-error-message-to-the-user-when-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope branch March 13, 2024 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants