-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ca 197 show an error message to the user when he tries to create an object with the same name as another object in the same scope #138
Merged
eric-intuitem
merged 11 commits into
main
from
CA-197-Show-an-error-message-to-the-user-when-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
Mar 13, 2024
Merged
Ca 197 show an error message to the user when he tries to create an object with the same name as another object in the same scope #138
eric-intuitem
merged 11 commits into
main
from
CA-197-Show-an-error-message-to-the-user-when-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
Missing test of uniqueness for threats
eric-intuitem
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are missing fields_to_check, which is not implicit anymore. I have added one for Threat, but there are others to consider.
eric-intuitem
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
…n-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
eric-intuitem
deleted the
CA-197-Show-an-error-message-to-the-user-when-he-tries-to-create-an-object-with-the-same-name-as-another-object-in-the-same-scope
branch
March 13, 2024 20:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.