fix: resilience evidence attachment missing

backend/core/models.py

@@ -1719,8 +1719,11 @@ def filename(self):
         return os.path.basename(self.attachment.name)
 
     def get_size(self):
-        if not self.attachment:
+        if not self.attachment or not self.attachment.storage.exists(
+            self.attachment.name
+        ):
             return None
+        # print("===>GET SIZE RAHHHHHHHH", self, self.attachment, self.attachment.size)
         # get the attachment size with the correct unit
         size = self.attachment.size
         if size < 1024:

backend/core/views.py

@@ -3131,10 +3131,14 @@ def attachment(self, request, pk):
         ) = RoleAssignment.get_accessible_object_ids(
             Folder.get_root_folder(), request.user, Evidence
         )
+        # print("==> ATTACHEMENT CALLED")
         response = Response(status=status.HTTP_403_FORBIDDEN)
         if UUID(pk) in object_ids_view:
             evidence = self.get_object()
-            if not evidence.attachment:
+            # print("=============\n",evidence.attachment.name,  evidence.attachment.storage.exists(evidence.attachment.name), "\n========")
+            if not evidence.attachment or not evidence.attachment.storage.exists(
+                evidence.attachment.name
+            ):
                 return Response(status=status.HTTP_404_NOT_FOUND)
             if request.method == "GET":
                 content_type = mimetypes.guess_type(evidence.filename())[0]

frontend/messages/en.json

@@ -774,6 +774,7 @@
 	"ShowAllNodesMessage": "Show all",
 	"ShowOnlyAssessable": "Only assessable",
 	"NoPreviewMessage": "No preview available.",
+	"couldNotFindAttachmentMessage": "Error: Could not find attachment.",
 	"licenseExpiredMessage": "Your license has expired. Write operations are disabled. Please contact your administrator to renew it.",
 	"experimental": "Experimental",
 	"timeline": "Timeline",

frontend/src/lib/components/ModelTable/EvidenceFilePreview.svelte

@@ -8,14 +8,19 @@
 	interface Attachment {
 		type: string;
 		url: string;
+		couldFetch: boolean;
 	}
 
 	let attachment: Attachment | undefined;
 
 	const fetchAttachment = async () => {
 		const res = await fetch(`/evidences/${meta.id}/attachment`);
 		const blob = await res.blob();
-		return { type: blob.type, url: URL.createObjectURL(blob) };
+		return {
+			type: blob.type,
+			url: URL.createObjectURL(blob),
+			couldFetch: res.ok || JSON.parse(await blob.text()).message != 'Failed to fetch attachment'
+		};
 	};
 
 	let mounted = false;
@@ -41,6 +46,8 @@
 			<img src={attachment.url} alt="attachment" class="h-24" />
 		{:else if attachment.type === 'application/pdf'}
 			<embed src={attachment.url} type="application/pdf" class="h-24" />
+		{:else if !attachment.couldFetch}
+			<p class="text-error-500 font-bold">{m.couldNotFindAttachmentMessage()}</p>
 		{:else}
 			<p>{m.NoPreviewMessage()}</p>
 		{/if}

frontend/src/routes/(app)/(third-party)/evidences/[id=uuid]/+page.svelte

@@ -19,6 +19,7 @@
 	interface Attachment {
 		type: string;
 		url: string;
+		couldFetch: boolean;
 	}
 
 	let attachment: Attachment | undefined = undefined;
@@ -49,7 +50,11 @@
 		const fetchAttachment = async () => {
 			const res = await fetch(`./${data.evidence.id}/attachment`);
 			const blob = await res.blob();
-			return { type: blob.type, url: URL.createObjectURL(blob) };
+			return {
+				type: blob.type,
+				url: URL.createObjectURL(blob),
+				couldFetch: res.ok || JSON.parse(await blob.text()).message != 'Failed to fetch attachment'
+			};
 		};
 		attachment = data.evidence.attachment ? await fetchAttachment() : undefined;
 	});
@@ -182,7 +187,11 @@
 					<embed src={attachment.url} type="application/pdf" width="100%" height="600px" />
 				{:else}
 					<div class="flex items-center justify-center space-x-4">
-						<p class="font-bold text-sm">{m.NoPreviewMessage()}</p>
+						{#if !attachment.couldFetch}
+							<p class="text-error-500 font-bold">{m.couldNotFindAttachmentMessage()}</p>
+						{:else}
+							<p class="font-bold text-sm">{m.NoPreviewMessage()}</p>
+						{/if}
 					</div>
 				{/if}
 			{:else}