Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter folders' queryset to domains #147

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be able to put assets and threats either in a domain or in the root folder (seen as "Global").
For other objects created by a user, they should be in a domain.
I have updated the architecture accordingly.

@nas-tabchiche
Copy link
Contributor Author

Creating a proxy model Domain, in the same fashion as Policy could save us a bit of headache here. This will make the distinction between domain and folder clearer in the codebase, and leave no room for confusion. I will do this first thing in the morning tomorrow

@eric-intuitem
Copy link
Collaborator

Simpler spec: anything put in the global folder has is_published=True. Only projects cannot be attached to the global folder, which is already implemented.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 953d333 into main Mar 15, 2024
11 checks passed
@eric-intuitem eric-intuitem deleted the CA-307-global-is-now-listed-in-domains-should-not branch March 15, 2024 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants