Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined risk-assessment status #191

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

monsieurswag
Copy link
Contributor

The risk-assessment status field is nullable, but the null value can't be translated especially because paraglide refuse to store null in its message dictionary (Error: Cannot compile message with ID "null").
So my only option was to use a ternary operator to translate null into "--".
You can change it to a better text before merging this PR if you find one.

@eric-intuitem eric-intuitem self-requested a review April 2, 2024 23:37
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 494d8b5 into main Apr 2, 2024
10 checks passed
@eric-intuitem eric-intuitem deleted the CA-342-Fix-undefined-risk-assessment-status branch April 2, 2024 23:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants