Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 352 prevent modal opening when mandatory objects are missing #204

Conversation

Mohamed-Hacene
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene commented Apr 5, 2024

This PR has a lot of commits because there is a problem with Fink online editor. It now pushes modifications in the root repository instead of the folder base location in /frontend/messages. It's nonsense because it's never done that before so I opened an issue to know more about it.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit eabb2e2 into main Apr 5, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@Mohamed-Hacene Mohamed-Hacene deleted the CA-352-Prevent-modal-opening-when-mandatory-objects-are-missing branch April 8, 2024 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants