Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The libary field of the frameworks detail view now display its name instead of its uuid #230

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

monsieurswag
Copy link
Contributor

No description provided.

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library field is not useless, it should be displayed properly, i.e. with its name, not its UUID.

@monsieurswag monsieurswag force-pushed the CA-356-fix-library-display-for-referential branch from 2b264fb to 899317d Compare April 9, 2024 00:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
@monsieurswag monsieurswag reopened this Apr 9, 2024
@monsieurswag
Copy link
Contributor Author

My bad i thought the "name" field always displayed the same name as the "libary" field, the problem is fixed

@monsieurswag monsieurswag force-pushed the CA-356-fix-library-display-for-referential branch from 2e5fb89 to 60093cd Compare April 9, 2024 00:27
@monsieurswag monsieurswag marked this pull request as draft April 9, 2024 00:28
@monsieurswag monsieurswag force-pushed the CA-356-fix-library-display-for-referential branch from 60093cd to 717a06d Compare April 9, 2024 00:31
@monsieurswag monsieurswag marked this pull request as ready for review April 9, 2024 00:31
@monsieurswag monsieurswag changed the title Remove useless library field from the frameworks detail view The libary field of the frameworks detail view now display its name instead of its uuid Apr 9, 2024
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit c1a1706 into main Apr 9, 2024
11 checks passed
@Mohamed-Hacene Mohamed-Hacene deleted the CA-356-fix-library-display-for-referential branch April 26, 2024 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants