Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/rename auditor #291

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Improve/rename auditor #291

merged 4 commits into from
Apr 19, 2024

Conversation

eric-intuitem
Copy link
Collaborator

auditor -> reader

@ab-smith
Copy link
Contributor

ab-smith commented Apr 18, 2024

impact on existing instance?
related to #278

@eric-intuitem
Copy link
Collaborator Author

No impact expected, as the code of the group has not been changed.

@eric-intuitem eric-intuitem marked this pull request as ready for review April 18, 2024 21:25
"auditor": "Auditeur",
"reader": "Auditeur",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation in french stays the same @eric-intuitem?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Solved.

Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@Mohamed-Hacene Mohamed-Hacene merged commit ebca222 into main Apr 19, 2024
12 checks passed
@Mohamed-Hacene Mohamed-Hacene deleted the improve/rename_auditor branch April 19, 2024 11:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants