Remove login_required decorator #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login_required decorator was used before we switched to DRF to redirect to login page if there were no user authenticated. Since we were using session authentication up until recently, the decorator had no impact on the proper functioning of the view, even though it overlapped with the permission_classes. It broke when we switched to token-based authentication, since it checks for session objects, which are no longer used.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login_required decorator was used before we switched to DRF to redirect to login page if there were no user authenticated. Since we were using session authentication up until recently, the decorator had no impact on the proper functioning of the view, even though it overlapped with the permission_classes.
It broke when we switched to token-based authentication, since it checks for session objects, which are no longer used.