Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/scores implementation groups #339

Merged
merged 21 commits into from
Apr 30, 2024

Conversation

eric-intuitem
Copy link
Collaborator

No description provided.

- rename score_definition -> scores_definition
- manage scores and implementation_groups in convert_framework
- adapt tisax converter
- rename maturity -> implementation_groups
- add implementation_groups_definition
- add selected_implementation_groups
- add selected boolean
- update tisax library
add tier score
TODO: add UX to allow selecting one of the hardcoded score scales (see spec)
copy of score parameters in models instead of in views
for existing assessments, fix score
fix custom migration
npm update
…ore.py

initialize score for all existing compliance assessment, as there is no default value
@eric-intuitem eric-intuitem marked this pull request as ready for review April 28, 2024 21:33
@eric-intuitem eric-intuitem marked this pull request as draft April 28, 2024 21:58
@eric-intuitem eric-intuitem marked this pull request as ready for review April 29, 2024 16:39
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nas-tabchiche nas-tabchiche merged commit a609726 into main Apr 30, 2024
10 checks passed
@nas-tabchiche nas-tabchiche deleted the improve/scores_implementation_groups branch April 30, 2024 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants