Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use test credential for Postgres #387

Merged
merged 1 commit into from
May 7, 2024
Merged

use test credential for Postgres #387

merged 1 commit into from
May 7, 2024

Conversation

eric-intuitem
Copy link
Collaborator

  • PG is running on localhost => no risk of undue access (moreover, this is only a test database)
  • This will allow external PR.
  • Also remove DJANGO_QECRET_KEY, which is selected randomly if not specified in environment

@eric-intuitem
use test credential for Postgres
fb91691 
- PG is running on localhost => no risk of undue access (moreover, this is only a test database)
- This will allow external PR.
- Also remove DJANGO_QECRET_KEY, which is selected randomly if not specified in environment
@gitguardian GitGuardian
Copy link

gitguardian bot commented May 7, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ab-smith ab-smith marked this pull request as ready for review May 7, 2024 20:03
@ab-smith ab-smith merged commit 8480447 into main May 7, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@Mohamed-Hacene Mohamed-Hacene deleted the fix/remove-remove-useless-secret-v2 branch May 30, 2024 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ab-smith ab-smith ab-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-intuitem @ab-smith