-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ca 141 prevent deleting a library that is in use in an assessment #40
Merged
eric-intuitem
merged 10 commits into
main
from
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
Feb 12, 2024
Merged
Ca 141 prevent deleting a library that is in use in an assessment #40
eric-intuitem
merged 10 commits into
main
from
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-intuitem
force-pushed
the
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
branch
from
February 12, 2024 20:58
a70bba8
to
69e8e22
Compare
nas-tabchiche
force-pushed
the
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
branch
from
February 12, 2024 20:58
69e8e22
to
16ad95e
Compare
Returning exception content as Response data discloses stack trace information
fix regression on library deletion
eric-intuitem
force-pushed
the
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
branch
from
February 12, 2024 23:32
cd036c9
to
f006604
Compare
eric-intuitem
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with fixed regression on deletion, LGTM
nas-tabchiche
deleted the
CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment
branch
February 13, 2024 12:42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.