Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 141 prevent deleting a library that is in use in an assessment #40

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

backend/library/views.py Fixed Show fixed Hide fixed
@nas-tabchiche nas-tabchiche marked this pull request as ready for review February 12, 2024 20:39
@eric-intuitem eric-intuitem force-pushed the CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment branch from a70bba8 to 69e8e22 Compare February 12, 2024 20:58
@nas-tabchiche nas-tabchiche force-pushed the CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment branch from 69e8e22 to 16ad95e Compare February 12, 2024 20:58
@eric-intuitem eric-intuitem force-pushed the CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment branch from cd036c9 to f006604 Compare February 12, 2024 23:32
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with fixed regression on deletion, LGTM

@eric-intuitem eric-intuitem merged commit d9a158f into main Feb 12, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
@nas-tabchiche nas-tabchiche deleted the CA-141-prevent-deleting-a-library-that-is-in-use-in-an-assessment branch February 13, 2024 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants