Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to CLoader for yaml #416

Merged
merged 4 commits into from
May 13, 2024
Merged

Switch to CLoader for yaml #416

merged 4 commits into from
May 13, 2024

Conversation

ab-smith
Copy link
Contributor

@ab-smith ab-smith commented May 12, 2024 •
edited
Loading

Got about 7x speed in yaml parsing with this tweak, if the yaml-cpp library is installed

@ab-smith ab-smith requested a review from eric-intuitem May 12, 2024 18:43
eric-intuitem
eric-intuitem approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab-smith ab-smith merged commit c4360c8 into main May 13, 2024
11 checks passed
@ab-smith ab-smith deleted the switch_to_CLoader branch May 13, 2024 02:35
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-intuitem eric-intuitem eric-intuitem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab-smith @eric-intuitem