Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tabgroup order deterministic in the project detail view #436

Conversation

monsieurswag
Copy link
Contributor

No description provided.

@monsieurswag monsieurswag force-pushed the CA-396-The-Risk-Assessment-and-Audit-tabgroups-order-is-random-in-the-project-detail-view branch from 566d7fe to d402c05 Compare May 15, 2024 17:01
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work, when I start from scratch, create a domain, a project, and from there an audit, the order of tabs (audit, risk assessment) changes.

@nas-tabchiche
Copy link
Contributor

nas-tabchiche commented May 16, 2024

@eric-intuitem wrapping the data.relatedModels sorting in a reactive statement does the trick. Should be good to merge now

Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 8884db5 into main May 16, 2024
11 checks passed
@eric-intuitem eric-intuitem deleted the CA-396-The-Risk-Assessment-and-Audit-tabgroups-order-is-random-in-the-project-detail-view branch May 16, 2024 21:20
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants