Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix probability and impact unused colors #514

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

monsieurswag
Copy link
Contributor

@monsieurswag monsieurswag commented Jun 4, 2024

Colors shall be defined for each "probability" and "impact" row in each matrix library YAML file before merging this PR.

@monsieurswag monsieurswag marked this pull request as draft June 4, 2024 09:35
@monsieurswag monsieurswag linked an issue Jun 4, 2024 that may be closed by this pull request
@monsieurswag monsieurswag marked this pull request as ready for review June 5, 2024 09:22
@monsieurswag monsieurswag marked this pull request as draft June 5, 2024 14:30
@monsieurswag
Copy link
Contributor Author

Colors should be displayed in some ways in /risk-matrices/{uuid}

@monsieurswag monsieurswag marked this pull request as ready for review June 7, 2024 08:29
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit dd17b99 into main Jun 7, 2024
15 checks passed
@eric-intuitem eric-intuitem deleted the fix/probability_and_impact_color_usage branch June 7, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors for probability and impact are not consistent
2 participants