Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can add evidences from applied controls #528

Closed

Conversation

monsieurswag
Copy link
Contributor

@monsieurswag monsieurswag commented Jun 7, 2024

This is an incomplete PR, the goal is to give user the ability to add evidences to its applied control directly from the detail view of its applied control.

Current problems :

  • The toast isn't displayed in the frontend (this is surely due to not using SuperForm with my buttons, but we could maybe just directly trigger the toast in the frontend).
  • The toast messages are not yet localized.
  • If the user has a lot of evidences he will have a hard time listing the evidences currently linked to its applied control
    • Solution 1: Adding a <input type="checkbox" ...> to filter the ModelTable to it only displays the evidences currently linked to the applied control
    • Solution 2 (which is better): Displaying a second ModelTable in a second tabgroup (the first ModelTable of the tabgroup being one displaying the evidences linked to the applied control and the second ModelTable displaying all existing evidences and allowing the user to link these evidences to its applied control).

@monsieurswag monsieurswag marked this pull request as draft June 7, 2024 20:10
@ab-smith ab-smith linked an issue Jun 9, 2024 that may be closed by this pull request
@AndrzejRPiotrowski
Copy link
Contributor

is this working solution ?

@ab-smith
Copy link
Contributor

not yet

@AndrzejRPiotrowski
Copy link
Contributor

not yet

Would be great to use this as well.

Toasts are not working good on Mobile (ciso-assistant) chrome.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@Mohamed-Hacene Mohamed-Hacene deleted the improve/add_evidences_from_applied_control branch September 18, 2024 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to attach existing evidences to applied controls
3 participants