Make modals persistents #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
2c88317 to
6bc27e6
Compare
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
3fcbaf2 to
0620a1b
Compare
monsieurswag
force-pushed
the
make_modals_persistents
branch
3 times, most recently
from
8ce351f to
750470e
Compare
…tion that don't success to redirect the client's location to /my-profile for whatever incomprehensible reason Remove tag
…have been executed in gitub actions Correct debug
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
70a1fee to
7d9f06c
Compare
Change tests again
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
a12adff to
b070250
Compare
… playwright command
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
d1fc4b6 to
c4d647d
Compare
monsieurswag
force-pushed
the
make_modals_persistents
branch
from
71c5751 to
d793a0c
Compare
|
Functional tests are fixed, we just have to fix the frontend linter issue then we can merge the PR. |
|
fixes #623 |
did npm install --save-dev prettier before
|
the cancel does clear out the modal but not the save, we need that as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.