Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/auto create suggested controls in audit #872

Merged
merged 41 commits into from
Sep 28, 2024
Merged

Feat/auto create suggested controls in audit #872

merged 41 commits into from
Sep 28, 2024

Conversation

nas-tabchiche
Copy link
Contributor

@nas-tabchiche nas-tabchiche commented Sep 25, 2024 •
edited by ab-smith
Loading

will fix #682

@nas-tabchiche
Write first implementation of RequirementAssessment.create_applied_co…
b95b533 
…ntrols_from_suggestions
@nas-tabchiche
Skip applied control creation if it already exists
e6329e7
@nas-tabchiche
Serialize create_applied_controls_from_suggestions boolean field
e74034a
@nas-tabchiche
Set requirement assessment applied controls after creating or getting…
8f68b0d 
… them
@nas-tabchiche
Implement create_applied_controls_from_suggestions field in UI
27f2aac
@nas-tabchiche
Only display create_applied_controls_from_suggestions on create form
3d73a4c
@nas-tabchiche
Display a loading placeholder while RecursiveTreeView component is be…
8943e3e 
…ing mounted

This greatly reduces the First Contentful Paint and Blocking Time of the
compliance assessment detail page.
@nas-tabchiche
Write create_suffested_applied_controls action
34c6987
@nas-tabchiche
Allow creating suggested controls from an existing audit
d216d47
@nas-tabchiche
Merge branch 'main' into feat/auto-create-suggested-controls-in-audit
b0da0ab
@nas-tabchiche
PoC: Create suggested controls from requirement assessment edit
01ea960
@nas-tabchiche
Give create_applied_controls_from_suggestions methods their own routes
d5bf48a
@nas-tabchiche
Implement RBAC for create_suggested_applied_controls methods
aa71f53
@nas-tabchiche
Merge branch 'main' into feat/auto-create-suggested-controls-in-audit
5cbdb24
@nas-tabchiche
Change create applied controls from suggestions button style
9662b06
@nas-tabchiche
Display create applied controls from suggestions button only if requi…
8f0cb41 
…rement assessment has suggested controls
@nas-tabchiche
Tidy unit tests
74cf596
@nas-tabchiche
Write unit test for create_applied_controls_from_suggestions
e7fbd80
@nas-tabchiche
Type create_requirement_assessments method
252ac29
@nas-tabchiche
Update unit test for create_applied_controls_from_suggestions
97e7c72
@nas-tabchiche
Fix add_appliedcontrol permission codename
d662eea
@nas-tabchiche
Add loading spinner while applied controls are being created
29dabc2
@nas-tabchiche
chore: Run ruff format
ce93394
@nas-tabchiche
Remove done TODO
7218136
@nas-tabchiche nas-tabchiche marked this pull request as ready for review September 26, 2024 15:43
@nas-tabchiche nas-tabchiche force-pushed the feat/auto-create-suggested-controls-in-audit branch from e3115bc to b9e5b21 Compare September 27, 2024 19:06
ab-smith
ab-smith approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@ab-smith ab-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok

@ab-smith ab-smith merged commit 08949b2 into main Sep 28, 2024
18 checks passed
@ab-smith ab-smith deleted the feat/auto-create-suggested-controls-in-audit branch September 28, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ab-smith ab-smith ab-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have an option to automatically create the suggested controls
2 participants
@nas-tabchiche @ab-smith