Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix delete library broken" #876

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Revert "fix delete library broken" #876

merged 1 commit into from
Sep 28, 2024

Conversation

ab-smith
Copy link
Contributor

This reverts commit 3d2d6a7.

@ab-smith ab-smith closed this Sep 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@ab-smith ab-smith reopened this Sep 28, 2024
@eric-intuitem eric-intuitem self-requested a review September 28, 2024 20:30
eric-intuitem
eric-intuitem approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hotfix but we still need to fix the regression on delete library.

@ab-smith ab-smith merged commit 9aac267 into main Sep 28, 2024
22 checks passed
@ab-smith ab-smith deleted the revert_fix_library_deletion branch September 28, 2024 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-intuitem eric-intuitem eric-intuitem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab-smith @eric-intuitem