Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the is_publised attribute in the AbstractBaseModel class #90

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Put the is_publised attribute in the AbstractBaseModel class #90

merged 12 commits into from
Mar 1, 2024

Conversation

monsieurswag
Copy link
Contributor

No description provided.

@eric-intuitem eric-intuitem self-requested a review February 28, 2024 23:39
eric-intuitem
eric-intuitem requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the new DoD.

@nas-tabchiche nas-tabchiche self-requested a review February 29, 2024 13:36
nas-tabchiche
nas-tabchiche requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things before we can merge this:

  • In object importers, just set is_published to True since imported library objects are always published anyway

    ciso-assistant-community/backend/library/utils.py

    Line 281 in fc86564

    is_published=self.security_function_data.get("is_published", True),
  • Add is_published=True to FrameworkImporter, RequirementNodeImporter and RiskMatrixImporter in import functions

eric-intuitem
eric-intuitem approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM. I have desquashed the migrations, and avoid useless overriding of field in library.

nas-tabchiche
nas-tabchiche approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nas-tabchiche nas-tabchiche merged commit 0984352 into main Mar 1, 2024
10 checks passed
@nas-tabchiche nas-tabchiche deleted the put_is_published_in_abstractbasemodel branch March 1, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-intuitem eric-intuitem eric-intuitem approved these changes

@nas-tabchiche nas-tabchiche nas-tabchiche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monsieurswag @nas-tabchiche @eric-intuitem