Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct plurial Questions or singular question #934

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

melinoix
Copy link
Contributor

Corrected and showed the number of question to the user to fill in a Audit with questions inside. if only one, 1 Question if more nth Questions

Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plural, not plurial

@eric-intuitem
Copy link
Collaborator

eric-intuitem commented Oct 14, 2024

I did not realised it was also within the questionnaire.
1/ Remove "x questions" line in the questionnaire, this is useless.
2/ Apply the correct plural form to the tag added in the compliance-assessments.

@eric-intuitem
Copy link
Collaborator

Works well. Let's provide all the translations to complete this task.

@Mohamed-Hacene Mohamed-Hacene self-requested a review October 16, 2024 14:01
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k, can be merged after resolving conflicts

…uitem/ciso-assistant-community into CA-510-improve-question-or-questions
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@Mohamed-Hacene Mohamed-Hacene self-requested a review October 18, 2024 11:27
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@Mohamed-Hacene Mohamed-Hacene self-requested a review October 18, 2024 11:28
@Mohamed-Hacene
Copy link
Collaborator

@nas-tabchiche needs to review it to approve the requested changes

Copy link
Contributor

@nas-tabchiche nas-tabchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nas-tabchiche nas-tabchiche merged commit d01f14d into main Oct 18, 2024
17 checks passed
@nas-tabchiche nas-tabchiche deleted the CA-510-improve-question-or-questions branch October 18, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants