Display folder field in evidence when creating from it from an applied control #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d control As an applied control may be global, inheriting its domain may cause errors if the user attempting to create an evidence inside it may not have the permission to create an evidence in the global domain.
nas-tabchiche
requested review from
ab-smith,
eric-intuitem and
Mohamed-Hacene
Mohamed-Hacene
requested changes
Oct 17, 2024
Mohamed-Hacene
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Let's merge it for now, to be able to add an evidence in a global applied control withtout having a global role.
Erratum: Evidence is conceptually part of applied control, and not just a linked object as in the database. It is preferable not to allow its modification without a global role. #956
Mohamed-Hacene
deleted the
fix/select-domain-in-global-object-nested-create
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an applied control may be global, inheriting its domain will cause errors if the user attempting to create an evidence inside it does not have the permission to create an evidence in the global domain.