Implement interval rounding #147
Conversation
test/interval.jl
Outdated
| @test_throws UndefKeywordError ceil(Interval(0.0, 1.0)) | ||
|
|
||
| @test ceil(Interval(0.0, 1.0), on=LeftEndpoint) == Interval(0.0, 1.0) | ||
| @test ceil(Interval(0.5, 1.0), on=LeftEndpoint) == Interval(1.0, 1.5) |
There was a problem hiding this comment.
I'm not sure on is the right keyword as it makes me think only the left would be changed. I'll think about a better name
There was a problem hiding this comment.
Thinking about it more I think this is just my personal bias and on is probably correct
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 75.76% 76.55% +0.78%
==========================================
Files 11 11
Lines 491 516 +25
==========================================
+ Hits 372 395 +23
- Misses 119 121 +2
Continue to review full report at Codecov.
|
test/interval.jl
Outdated
| @test_throws UndefKeywordError ceil(Interval(0.0, 1.0)) | ||
|
|
||
| @test ceil(Interval(0.0, 1.0), on=LeftEndpoint) == Interval(0.0, 1.0) | ||
| @test ceil(Interval(0.5, 1.0), on=LeftEndpoint) == Interval(1.0, 1.5) |
There was a problem hiding this comment.
Thinking about it more I think this is just my personal bias and on is probably correct
|
|
||
| See also: [`LeftEndpoint`](@ref) | ||
| """ | ||
| const RightEndpoint{T,B} = Endpoint{T, Right, B} where {T,B <: Bound} |
There was a problem hiding this comment.
I wouldn't mind the docstrings being in a set PR
nicoleepp
force-pushed
the
ne/rounding
branch
from
3a36368 to
cfc2c13
Compare
Supersedes #65
Closes #146
Still needs documentation additions but should be ready for initial reviewNow has documentation