Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emails: add notification email details #751

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented Mar 19, 2025

❤️ Thank you for your contribution!

Description

Copies the notification email config from https://inveniordm.docs.cern.ch/releases/v11/version-v11.0.0/#reports to the email section.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I've created logical separate commits and followed the commit message format.
  • I've targeted the master branch.
  • If this documentation change impacts the current release of InvenioRDM, I will backport it to the production branch following approval or indicate to a maintainer that it should be backported.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can be merged after comments addressed to your liking.


- `MAIL_DEFAULT_SENDER`: modifies the e-mail sender (field `from`).
- `APP_RDM_ADMIN_EMAIL_RECIPIENT`: modifies the e-mail recipient (field `to`).
- `FILES_INTEGRITY_REPORT_SUBJECT`: modifies the subject of the e-mail (field `subject`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the FILES_INTEGRITY_REPORT_SUBJECT from this section since it's more specific to one notification in particular (it's given as example below, so we don't lose informative documentation).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've moved it!

@tmorrell tmorrell merged commit 0b2879c into inveniosoftware:master Mar 19, 2025
1 check passed
tmorrell added a commit that referenced this pull request Mar 19, 2025
* emails: add notification email details

* emails: move subject to template section

Co-authored-by: Guillaume Viger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants