Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#855] 5-6) wait, decision, expiration, notification flows #1175

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

fenekku
Copy link
Contributor

@fenekku fenekku commented Jul 23, 2024

Implements wait, role change, decision, expiration, notification flows

  • adapt community header after request from requester's perspective

membership_discussion_link_records_page

membership_discussion_link

  • show membership requests in community from reviewer's perspective
    membership_requests_in_community_page

  • show membership requests in dashboard from requester's side
    requests_by_user_page

  • don't show membership requests in normal community requests from reviewer's perspective
    requests_for_comunity_page

  • Bonus: serialize links for member API correctly. This allows the cancellation of Invitations from the listing directly:

image

  • Can't invite member that already requested membership

cant_invite_already_requested

  • Bonus: For discussion pages in community, show proper tabs (Member tab wasn't shown before for invitation discussion for instance)

discussion_in_community_page

  • implements role change, cancel, decline, expire, accept

  • implement notifications emails

  • Bonus: Fix display of expiry time to be consistent across discussion page and listing (wasn't the case for invitations either)

@fenekku fenekku changed the title 855 6 decision flow [#855] 6) decision, expiration, notification flows Jul 25, 2024
@fenekku fenekku changed the title [#855] 6) decision, expiration, notification flows [WIP][#855] 6) decision, expiration, notification flows Jul 26, 2024
@fenekku fenekku force-pushed the 855_6_decision_flow branch 2 times, most recently from 5bc4e7d to 2f38cc6 Compare July 30, 2024 12:46
@fenekku fenekku mentioned this pull request Jul 30, 2024
4 tasks
@fenekku fenekku force-pushed the 855_6_decision_flow branch from 2f38cc6 to 14311de Compare July 30, 2024 12:54
@fenekku fenekku changed the title [WIP][#855] 6) decision, expiration, notification flows [#855] 5-6) wait, decision, expiration, notification flows Jul 30, 2024
@fenekku fenekku force-pushed the 855_6_decision_flow branch from 64adcdb to d9d8986 Compare July 30, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant