-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#855] 5-6) wait, decision, expiration, notification flows #1175
Open
fenekku
wants to merge
9
commits into
inveniosoftware:master
Choose a base branch
from
fenekku:855_6_decision_flow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenekku
changed the title
855 6 decision flow
[#855] 6) decision, expiration, notification flows
Jul 25, 2024
fenekku
changed the title
[#855] 6) decision, expiration, notification flows
[WIP][#855] 6) decision, expiration, notification flows
Jul 26, 2024
fenekku
force-pushed
the
855_6_decision_flow
branch
2 times, most recently
from
July 30, 2024 12:46
5bc4e7d
to
2f38cc6
Compare
4 tasks
- update role - addressed TODOs
…C-offset datetime string
… email notification
fenekku
force-pushed
the
855_6_decision_flow
branch
from
July 30, 2024 12:54
2f38cc6
to
14311de
Compare
fenekku
changed the title
[WIP][#855] 6) decision, expiration, notification flows
[#855] 5-6) wait, decision, expiration, notification flows
Jul 30, 2024
fenekku
force-pushed
the
855_6_decision_flow
branch
from
July 30, 2024 19:48
64adcdb
to
d9d8986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements wait, role change, decision, expiration, notification flows
show membership requests in community from reviewer's perspective
show membership requests in dashboard from requester's side
don't show membership requests in normal community requests from reviewer's perspective
Bonus: serialize links for member API correctly. This allows the cancellation of Invitations from the listing directly:
implements role change, cancel, decline, expire, accept
implement notifications emails
Bonus: Fix display of expiry time to be consistent across discussion page and listing (wasn't the case for invitations either)