Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datamodel: test/display organizational entity #77

Merged
merged 3 commits into from
Mar 18, 2020
Merged

datamodel: test/display organizational entity #77

merged 3 commits into from
Mar 18, 2020

Conversation

fenekku
Copy link
Contributor

@fenekku fenekku commented Mar 12, 2020 •
edited
Loading

closes #52
closes #78
closes #61

@fenekku
dependencies: fixes for upstream changes [more]
f113b09 
- Allow wider range on pytest: seems fine...
- Make dependency on invenio-records-ui explicit:
  we are depending on it directly in the code, but didn't
  list it directly in the dependencies. It worked because
  it was a dependency of a dependency.
- Allow wider range on invenio-pidstore: seems fine...
@fenekku fenekku requested a review from lnielsen March 16, 2020 19:05
@fenekku
Copy link
Contributor Author

fenekku commented Mar 16, 2020 •
edited
Loading

@lnielsen this can be reviewed again. Let me check some things first.

Top-level identifiers field and the identifiers field in creators or contributors have been changed. Other instances where identifiers are listed have been left alone until we get to them (they have more fields than just scheme + identifier).

@fenekku fenekku changed the title datamodel: test/display organizational entity [WIP] datamodel: test/display organizational entity Mar 17, 2020
@fenekku fenekku changed the title [WIP] datamodel: test/display organizational entity datamodel: test/display organizational entity Mar 17, 2020
@fenekku
Copy link
Contributor Author

fenekku commented Mar 17, 2020

@lnielsen @zzacharo @ppanero Now it's ready to be (re)-reviewed.

lnielsen
lnielsen approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@lnielsen lnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only clarification for me for merging this PR is the scheme names.

@fenekku fenekku merged commit 7a0c09f into inveniosoftware:master Mar 18, 2020
@fenekku fenekku deleted the 52_organizations branch March 18, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnielsen lnielsen lnielsen approved these changes

@ppanero ppanero Awaiting requested review from ppanero

@zzacharo zzacharo Awaiting requested review from zzacharo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fenekku @lnielsen