Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: allow request search configuration #386

Merged
merged 1 commit into from
Jun 24, 2024
Merged

config: allow request search configuration #386

merged 1 commit into from
Jun 24, 2024

Conversation

egabancho
Copy link
Member

@egabancho
Copy link
Member Author

If I'm not mistaken, with this change fa4c815 we won't be able to use this until we update the v13 (maybe v12.1).

Is there any way we can backport this or maybe relax the requirements on setup.cfg invenio-records-resources>=5.0.0,<7.0.0?

@egabancho egabancho requested a review from fenekku June 24, 2024 08:41
@fenekku
Copy link
Contributor

fenekku commented Jun 24, 2024

Is there any way we can backport this

Yes. I made a ticket for it: #387 👍 .

fenekku
fenekku approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was needed, Thanks for that!

@fenekku fenekku merged commit b1b126a into inveniosoftware:master Jun 24, 2024
2 checks passed
@egabancho egabancho deleted the requests-search-config branch July 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenekku fenekku fenekku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow request search configuration
2 participants
@egabancho @fenekku