Minor updates #136
Merged
Minor updates #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-moser
commented
Mar 30, 2023
Comment on lines
+342
to
+344
| doc = aggregation.top_hit.hits.hits[0]["_source"].to_dict() | ||
| aggregation = aggregation.to_dict() |
There was a problem hiding this comment.
The issue linked in the commit won't happen with the code as is right now because we're only using "leaf node" values (integers, strings, etc.).
If one of the values we reuse should be a dictionary however, it would be a DSL object (e.g. AttrList) instead, and cause issues when trying to reindex.
ntarocco
reviewed
Mar 30, 2023
* because we don't need the actual query hits, we just need the aggregations * also, remove the unused temporary variable assignment
* because we're reusing parts of the aggregation query results directly, and per default they're wrapped in DSL objects (e.g. AttrList) that aren't JSON-serializable * see: elastic/elasticsearch-dsl-py#913
fenekku
approved these changes
May 2, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks some minor updates from the closed "bucket aggregations" PR.
Nothing dramatic, just nice-to-haves.