Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barcode validation fix #9127

Merged

Conversation

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed barcode Barcode scanning and integration backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch order Related to purchase orders / sales orders labels Feb 21, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit dd89f2b
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67b84d5679d3e5000826c671

Revert typo fix

- Otherwise, we need to do an API bump and the PR can't be back-ported!
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (ab4eff1) to head (dd89f2b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...kend/InvenTree/plugin/base/barcodes/serializers.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9127   +/-   ##
=======================================
  Coverage   86.03%   86.04%           
=======================================
  Files        1177     1177           
  Lines       51944    51944           
  Branches     2130     2130           
=======================================
+ Hits        44691    44694    +3     
+ Misses       6709     6706    -3     
  Partials      544      544           
Flag Coverage Δ
backend 88.08% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit bc9dbf7 into inventree:master Feb 21, 2025
27 checks passed
@SchrodingersGat SchrodingersGat deleted the barcode-validation-fix branch February 21, 2025 11:17
github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
* Fix logic for adding items to SalesOrder

* Same thing for purchase orders

* Update serializers.py

Revert typo fix

- Otherwise, we need to do an API bump and the PR can't be back-ported!

(cherry picked from commit bc9dbf7)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Feb 21, 2025
* Fix logic for adding items to SalesOrder

* Same thing for purchase orders

* Update serializers.py

Revert typo fix

- Otherwise, we need to do an API bump and the PR can't be back-ported!

(cherry picked from commit bc9dbf7)

Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch barcode Barcode scanning and integration bug Identifies a bug which needs to be addressed order Related to purchase orders / sales orders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant