Update npm packages including express #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @irfanh94, thank you so much for your contribution. I just updated dependencies myself, but I did not update |
cc: @notaphplover |
| "express" | ||
| ], | ||
| "dependencies": { | ||
| "express": "4.21.1", |
There was a problem hiding this comment.
This should be a peer dependency I'm afraid. Let's allow any minor:
"express": "^4.21.1",
| "dependencies": { | ||
| "express": "4.21.1", | ||
| "http-status-codes": "2.3.0", | ||
| "inversify": "^6.0.3" |
There was a problem hiding this comment.
This should be a peer dependency as well.
| @@ -11,4 +11,4 @@ export * from './debug'; | |||
| export * from './httpResponseMessage'; | |||
| export * from './content/stringContent'; | |||
| export * from './content/jsonContent'; | |||
| export * from './content/httpContent'; | |||
| export * from './content/httpContent'; | |||
| "devDependencies": { | ||
| "@types/async": "3.2.24", | ||
| "@types/cookie-parser": "1.4.7", | ||
| "@types/express": "4.17.21", |
There was a problem hiding this comment.
Let's allow any minor:
"@types/express": "^4.17.21",
notaphplover
added a commit
that referenced
this pull request
Oct 25, 2024
This reverts commit a0ee887.
notaphplover
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates several npm packages, with the main focus on updating the
expresspackage to its latest version. It ensures compatibility with the updated dependencies and applies minor fixes where necessary to avoid potential issues caused by outdated packages.Related Issue
No specific issue is linked to this PR. This update is primarily to maintain the project's health by keeping dependencies up to date.
Motivation and Context
Keeping dependencies up to date is important for security, performance, and compatibility reasons. The main motivation behind this PR is to upgrade
expressand ensure that the project continues to function smoothly with the latest version.How Has This Been Tested?
npm run test, and all tests passed successfully.Types of changes
Checklist: