Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add global dependency overrides #520

Closed

Conversation

jtdLab
Copy link
Contributor

@jtdLab jtdLab commented May 15, 2023

Description

Support global dependency_overrides (#439)

This allows to define dependency overrides for each workspace package in melos.yaml like:

name: foo

packages:
  - packages/**

globalDependencyOverrides:
  my_dependency: 1.2.3

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@docs-page
Copy link

docs-page bot commented May 15, 2023

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~520

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

@jtdLab jtdLab changed the title Feat global dependency overrides feat: Add global dependency overrides May 15, 2023
@jtdLab
Copy link
Contributor Author

jtdLab commented May 15, 2023

Hint:

The added globalDependencyOverrides and the existing dependencyOverridePaths do add the dependency override(s) to all workspace packages. This means packages that do not have a regular or dev dependency also get the override(s) which seems to be bad. Is this behaviour intended?

@blaugold
Copy link
Collaborator

@jtdLab Thanks for this contribution!

We already have dependencyOverridePaths . Could you make the new option a sibling of that one? I think dependencyOverrides would be enough as its name. Please also document the new option.

Is this behaviour intended?

Yes. Often, dependency overrides are used to override transitive dependencies.

@jtdLab
Copy link
Contributor Author

jtdLab commented May 15, 2023

@blaugold i am no sure about the docs is it only the overview page which needs an update?

@jtdLab
Copy link
Contributor Author

jtdLab commented Jul 12, 2023

Any updates on this?

@jtdLab
Copy link
Contributor Author

jtdLab commented Sep 20, 2023

@blaugold @Salakar can some check this pr?

@spydon
Copy link
Collaborator

spydon commented Dec 28, 2023

@jtdLab this is offering the same functionality as #594 right?

@spydon
Copy link
Collaborator

spydon commented Mar 11, 2024

I'll close this since the functionality will be implemented with the new system in 594, thanks for the effort though!

@spydon spydon closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants