-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): deprecation warning for v8 API ahead of future major release #8132
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm 100% certain people use the utils stuff, it is useful for at least 2 common scenarios:
link to actually useful docs is https://rnfirebase.io/app/utils (the typedoc render of it is awful / useless) It's typed pretty rough though from a typescript and typedoc perspect and there may be a better way to expose this functionality. It does need a home though IMHO |
Yeah, I left it because I thought it was useful but I was caught in a bind between utility vs matching v9 API. So thought I'd pose the question. FYI; Tests won't pass here until Crashlytics is merged as there's an e2e test that uses console.warn 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
There is also a
utils()
method on FirebaseApp: https://rnfirebase.io/reference/app#utilsNot sure whether to leave it or to remove.
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter