Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android, app): fix hot-reload on react-native <= 0.73 #8160

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(android, app): fix hot-reload on react-native <= 0.73 #8160

merged 1 commit into from
Nov 25, 2024
+11 −7

Commits on Nov 25, 2024

  1. fix(android, app): fix hot-reload on react-native <= 0.73 

    super.invalidate() is an empty function in rn >= 0.74, so no
need to call it going forward

But on rn <= 0.73 it may not exist, and if it does it calls
onCatalystInstanceDestroy which makes for a StackOverFlowException
as we go recursive
    @mikehardy
    mikehardy committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7e1c351 View commit details
    Browse the repository at this point in the history