feat(auth): validatePassword method implementation #8400
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| let schemaVersion = 1; | ||
|
|
||
| try { | ||
| // Identity toolkit API endpoint for password policy. Ensure this is enabled on Google cloud. |
There was a problem hiding this comment.
I seem to recall you suffered this error didn't you? Do you remember anything characteristic about the error that could be used to identify it for developers. Then we could document it perhaps. Might make sense to mention it specifically in the API doc either way ("Verify in Google Cloud Project that your API key has access too XYZ") whatever XYZ is
There was a problem hiding this comment.
If you ensure the identity toolkit api is enabled on google cloud console and that your firebase console api key has access to it, it should be fine. Should I append this to documentation or here?
There was a problem hiding this comment.
Should I append this to documentation
The goal is to make it discoverable for developers. I think the quickest way to do that for something API specific like this, is in the API doc that will be rendered into the reference website for APIs
There was a problem hiding this comment.
Still needs this resolved - just to add a quick note in the comment section of the API for this ?
| @@ -0,0 +1,132 @@ | |||
| /* | |||
| * Copyright (c) 2016-present Invertase Limited & Contributors | |||
There was a problem hiding this comment.
Did you use any Google firebase-js-sdk code for this? If so I think we need to do the Co-Authored-By: <foo@google.com> for all authors trick that was used for vertexai, based on the committers for the file(s) you used
There was a problem hiding this comment.
In here, it has been brought over from the JS-SDK so I can put the co-authored part in.
- cleanly split between namespace / modular - some sections were mixed - remove empty block avoiding test - fix double-nesting on ActionCodeSettings
Description
Implement validatePassword() method and match implementation to JS-SDK: https://github.com/firebase/firebase-js-sdk/blob/main/packages/auth/src/core/index.ts#L116
Draft: still needs implementation and e2e tests properly functioning.
closes #8359
Related issues
Fixes #8359
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter