test: tighten rules-unit-testing patch, matches upstream PR attempt #8421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doing some dependency upgrades and I always look to trim the count of patches we carry, attempting to upstream this one now and the PR I proposed (after testing it...) is more minimal than our current in-tree patch, synching it here
works in testing, is minimal compared to previous
Related issues
See:
Release Summary
Test-only code, no release
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Most of the database e2e tests uses the
database/e2e/helpers.js::seed
function, which uses this rules-unit-testing feature requiring the patch, if database e2e passes this works - and it passes for me locallyThink
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter