Skip to content

fix(auth,ios): fixes inappropriate linking when host is nil #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yjb94
Copy link

@yjb94 yjb94 commented May 7, 2025

Description

I have a universal link that has nothing to do with firebase. but when i link into the url, the link has nil url host and falls into the generated expo prebuild linking code and returns NO. which is inappropriate and needed that url to pass to the very bottom of the linking delegate code.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

you can test with url with nullable(nil) url host. in my case, i tested with a custom universal link that has nothing to do with firebase app


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 7:53am

@CLAassistant
Copy link

CLAassistant commented May 7, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yjb94 yjb94 changed the title fix(auth,ios): fixes inappropriate branching when host is nil fix(auth,ios): fixes inappropriate linking when host is nil May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants