Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change something in _read_packets #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edelangh
Copy link

I've some trouble to connect to socket.io server 2.1.1
I've made this change, and now everything works well.

I've some trouble to connect to socket.io server 2.1.1
I've made this change, and now everything works well.
@WhiteExponent
Copy link

WhiteExponent commented Jan 3, 2020

Yeah, for some reason the old code checks for a 0xFF byte, when the protocol specification says that the packet length is followed by a :.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants