Completely replace ProdServ identity type with key

invopop · Aug 18, 2023 · 7dae90b · 7dae90b
1 parent 998cc80
commit 7dae90b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/regimes/mx/item.go b/regimes/mx/item.go
@@ -42,7 +42,7 @@ func validItemIdentities(value interface{}) error {
 
 func normalizeItem(item *org.Item) error {
 	for _, id := range item.Identities {
-		if id.Type == IdentityTypeSAT && itemIdentityNormalizableCodeRegexp.MatchString(string(id.Code)) {
+		if id.Key == IdentityKeyCFDIProdServ && itemIdentityNormalizableCodeRegexp.MatchString(string(id.Code)) {
 			id.Code = id.Code + "00"
 		}
 	}

diff --git a/regimes/mx/item_test.go b/regimes/mx/item_test.go
@@ -89,7 +89,7 @@ func TestItemIdentityNormalization(t *testing.T) {
 		},
 	}
 	for _, ts := range tests {
-		item := &org.Item{Identities: []*org.Identity{{Code: ts.Code, Type: "SAT"}}}
+		item := &org.Item{Identities: []*org.Identity{{Code: ts.Code, Key: mx.IdentityKeyCFDIProdServ}}}
 		err := r.CalculateObject(item)
 		assert.NoError(t, err)
 		assert.Equal(t, ts.Expected, item.Identities[0].Code)

diff --git a/regimes/mx/mx.go b/regimes/mx/mx.go
@@ -21,8 +21,6 @@ const (
 	KeySATFormaPago         cbc.Key = "sat-forma-pago"          // for mapping to c_FormaPago’s codes
 	KeySATTipoDeComprobante cbc.Key = "sat-tipo-de-comprobante" // for mapping to c_TipoDeComprobante’s codes
 	KeySATTipoRelacion      cbc.Key = "sat-tipo-relacion"       // for mapping to c_TipoRelacion’s codes
-
-	IdentityTypeSAT cbc.Code = "SAT" // for custom codes mapped from identities (e.g. c_ClaveProdServ’s codes)
 )
 
 // SAT official codes to include in stamps.