Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Rechnung Add-on #393

Merged
merged 26 commits into from
Oct 31, 2024
Merged

X-Rechnung Add-on #393

merged 26 commits into from
Oct 31, 2024

Conversation

apardods
Copy link
Contributor

@apardods apardods commented Oct 15, 2024

  • Added de-xrechnung-v3 addon.
  • Added eu-en16931-v2017 addon that handles universal normalization and validation required for compliance.
  • Added iso and untdid "catalogues" used for storing universally available extensions.
  • Removed Payment UNTDID references, now supported by catalogues.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 91.54676% with 47 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (1b4a1e7) to head (219651d).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
addons/de/xrechnung/instructions.go 86.15% 6 Missing and 3 partials ⚠️
bill/charges.go 65.21% 7 Missing and 1 partial ⚠️
bill/discounts.go 68.18% 6 Missing and 1 partial ⚠️
org/inbox.go 87.87% 3 Missing and 1 partial ⚠️
addons/de/xrechnung/invoices.go 89.65% 2 Missing and 1 partial ⚠️
addons/eu/en16931/bill.go 93.02% 2 Missing and 1 partial ⚠️
tax/regime_def.go 82.35% 2 Missing and 1 partial ⚠️
tax/tax.go 82.35% 2 Missing and 1 partial ⚠️
addons/eu/en16931/scenarios.go 0.00% 2 Missing ⚠️
bill/invoice.go 33.33% 0 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   79.04%   80.27%   +1.22%     
==========================================
  Files         220      232      +12     
  Lines       10811    11251     +440     
==========================================
+ Hits         8546     9032     +486     
+ Misses       1910     1857      -53     
- Partials      355      362       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its going in the right direction, but lot's of changes required. Please do closely look at the other example addons to make sure everything is as similar as possible. Take special note of the usage of validation.Skip for example also, this is important.

addons/de/xrechnung/extensions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions.go Outdated Show resolved Hide resolved
addons/de/xrechnung/instructions_test.go Outdated Show resolved Hide resolved
addons/de/xrechnung/invoices.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cavalle cavalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Totally feels like the right way to separate the extensions, scenarios, validations and normalisations derived from EN16931 from those derived from each specific CIUS/Extension.

@samlown samlown merged commit 2c62b5c into main Oct 31, 2024
7 checks passed
@samlown samlown deleted the addon-de branch October 31, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants