-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-Rechnung Add-on #393
X-Rechnung Add-on #393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 79.04% 80.27% +1.22%
==========================================
Files 220 232 +12
Lines 10811 11251 +440
==========================================
+ Hits 8546 9032 +486
+ Misses 1910 1857 -53
- Partials 355 362 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its going in the right direction, but lot's of changes required. Please do closely look at the other example addons to make sure everything is as similar as possible. Take special note of the usage of validation.Skip
for example also, this is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Totally feels like the right way to separate the extensions, scenarios, validations and normalisations derived from EN16931 from those derived from each specific CIUS/Extension.
de-xrechnung-v3
addon.eu-en16931-v2017
addon that handles universal normalization and validation required for compliance.iso
anduntdid
"catalogues" used for storing universally available extensions.