Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper regime when alternative code is given #399

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Oct 21, 2024

Describe your changes

Sets the proper tax regime code (e.g. EL) when the alternative code is given (e.g. GR)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • Requested a review from @samlown.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (15397b4) to head (41f1403).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   78.82%   78.88%   +0.05%     
==========================================
  Files         217      217              
  Lines       10721    10722       +1     
==========================================
+ Hits         8451     8458       +7     
+ Misses       1914     1909       -5     
+ Partials      356      355       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cavalle cavalle requested a review from samlown October 21, 2024 14:34
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That's what I was expecting 👍

@cavalle cavalle merged commit 46e9b2c into main Oct 21, 2024
7 checks passed
@cavalle cavalle deleted the fix-set-regime branch October 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants