-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions and validations for the typical service note #429
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 81.45% 81.48% +0.03%
==========================================
Files 232 233 +1
Lines 11468 11491 +23
==========================================
+ Hits 9341 9364 +23
Misses 1764 1764
Partials 363 363 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
9047358
to
ebd7c83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I've made a new suggestion for the "simples-nacional" to consider.
Describe your changes
Adds extensions (
br-nfse-cnae
,br-nfse-iss-liability
) and validations used in the "typical" (80/20) service note.Checklist before requesting a review
go generate .
to ensure that Schemas and Regime data are up to date.