Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions and validations for the typical service note #429

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Nov 19, 2024

Describe your changes

Adds extensions (br-nfse-cnae, br-nfse-iss-liability) and validations used in the "typical" (80/20) service note.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • I've run go generate . to ensure that Schemas and Regime data are up to date.
  • All linter warnings have been reviewed and fixed.
  • I've been obsessive with pointer nil checks to avoid panics.
  • The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (20f27e6) to head (44a3b9e).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   81.45%   81.48%   +0.03%     
==========================================
  Files         232      233       +1     
  Lines       11468    11491      +23     
==========================================
+ Hits         9341     9364      +23     
  Misses       1764     1764              
  Partials      363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cavalle cavalle marked this pull request as ready for review November 21, 2024 11:17
@cavalle cavalle requested a review from samlown November 21, 2024 11:17
Copy link
Collaborator

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I've made a new suggestion for the "simples-nacional" to consider.

addons/br/nfse/extensions.go Outdated Show resolved Hide resolved
Base automatically changed from br-issuer to main November 21, 2024 16:06
@cavalle cavalle merged commit 27c9101 into main Nov 21, 2024
4 checks passed
@cavalle cavalle deleted the br-typical-nfse branch November 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants