Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Greece examples #436

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix Greece examples #436

merged 1 commit into from
Nov 28, 2024

Conversation

cavalle
Copy link
Contributor

@cavalle cavalle commented Nov 28, 2024

Describe your changes

Greece examples weren't up-to-date with recent changes.

This PR also updates the suppliers tax ID to use the one pre-registered in the sandbox environment of the ILYDA app.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • [N/A] I have added thorough tests with at least 90% code coverage.
  • I've modified or created example GOBL documents the show my changes in use, if appropriate.
  • [N/A] When adding or modifying a tax regime or addon, I've added links to the source of the changes either structured or in the comments.
  • [N/A] I've run go generate . to ensure that Schemas and Regime data are up to date.
  • [N/A] All linter warnings have been reviewed and fixed.
  • [N/A] I've been obsessive with pointer nil checks to avoid panics.
  • [N/A] The CHANGELOG.md has been updated with an overview of my changes.
  • Requested a review from @samlown.

@cavalle cavalle requested a review from samlown November 28, 2024 09:23
@samlown samlown merged commit e723e14 into main Nov 28, 2024
7 checks passed
@samlown samlown deleted the fix-gr-examples branch November 28, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants