add openssh-client to devcontainer #1136
Conversation
|
How would you test such a change? Is there a test which validates that the DevContainer is actually working? |
|
@AlCalzone anything open from your side or can we merge this? |
| @@ -8,6 +8,9 @@ const templateFunction: TemplateFunction = answers => { | |||
| const template = ` | |||
| FROM iobroker/iobroker:latest | |||
| RUN ln -s /opt/iobroker/node_modules/ /root/.node_modules | |||
| # Needed to use git-ssh in devcontainer | |||
| RUN apt-get update &&\\ | |||
| apt-get -y --no-install-recommends install openssh-client | |||
There was a problem hiding this comment.
Formatting here seems to mix tabs and spaces, would be great to have this consistent (tabs):
There was a problem hiding this comment.
done
Whats the fundamental process here? Tabs are used for the code in the create-adapter projects. Thats fine - but the indentation within the template should follow the answer the user gives for indendation, shouldn't it? Currently the templates use a mix of spaces and tabs depending which file is in focus. I changed it to tabs now bc. of the review comment but if a user wants to have spaces, will they get a issue?
| @@ -8,6 +8,9 @@ const templateFunction: TemplateFunction = answers => { | |||
| const template = ` | |||
| FROM iobroker/iobroker:latest | |||
| RUN ln -s /opt/iobroker/node_modules/ /root/.node_modules | |||
| # Needed to use git-ssh in devcontainer | |||
| RUN apt-get update &&\\ | |||
There was a problem hiding this comment.
This is more of a personal preference, but I find multiline Docker commands easier to grasp if there is a space before the "newline" backspace, and the && is in the next line before the 2nd command.
CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ | |||
| ## __WORK IN PROGRESS__ | |||
| (at the beginning of a new line) | |||
| --> | |||
|
|
|||
| ## __WORK IN PROGRESS__ | |||
| * (hacki11) Support git-ssh in devcontainer (#1136) | |||
There was a problem hiding this comment.
There should be a link to your migration guide, see for example the 2.6.0 changelog.
PR Checklist:
npm run buildnpm test.github/create_templates.ts)docs/updatesexplaining what the user needs to do when manually updating an existing projectCHANGELOG.md(referencing the migration description and this PR or the issue you fixed)Description:
As a developer, I want to commit & push to the adapters git repository I cloned with a ssh url instead of https.
The current iobroker docker image does not include openssh-client, so ssh is not working. This PR changes that.