Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows paths handling #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

plu5
Copy link

@plu5 plu5 commented Apr 20, 2024

On Windows, pathlib paths are of type WindowsPath, so do not pass type(path) is PosixPath checks. Check instead for the parent class Path, so that both PosixPath and WindowsPath get correctly handled.

This caused sqlite queries in db.py functions to fail with:

sqlite3.InterfaceError: Error binding parameter 1 - probably unsupported type.

because instead of str, WindowsPath was being passed as the file_path parameter.

On Windows, pathlib paths are of type WindowsPath, so do not pass
`type(path) is PosixPath` checks. Check instead for the parent class Path,
so that both PosixPath and WindowsPath get correctly handled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant