Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(segment-button): ensure ion-text inside segment button will have the same visuals as ion-label #30328

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

fix(segment-button): ensure ion-text inside segment button will have the same visuals as ion-label #30328

wants to merge 3 commits into from

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

Issue number: internal

What is the current behavior?

  • The segment button is expecting an ion-label, however on OutSystems we were using the ion-text, since the experience is using the Mobile Text widget.

What is the new behavior?

  • add styles for ion-text in every instance we were customize ion-label;

Does this introduce a breaking change?

  • Yes
  • No

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the type: bug a confirmed bug report label Apr 1, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:29pm

@github-actions github-actions bot added the package: core @ionic/core package label Apr 1, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review April 1, 2025 16:31
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner April 1, 2025 16:31
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested review from christian-bromann and removed request for christian-bromann April 1, 2025 16:31
@brandyscarney
Copy link
Member

Can we close this since it isn't being implemented this way now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoFerreira-FrontEnd @brandyscarney