This repository has been archived by the owner on May 4, 2022. It is now read-only.
Fix: #1049 (Android 9 ion-input initial tap problem) #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix for Android Pi (9) <ion-input> first time tap not working. Plus some minor TypeScript updates which should not affect anything.
StefanRein
changed the title
|
Waiting for this PR to be approved |
|
I'm running into this same issue. Is there a reason this pull request isn't being merged? |
|
We have this issue as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for Android Pi (9) first time tap not working.
Short description of what this resolves:
This resolves the issue, that on Android 9 the first tap without setting focus with user interaction will not let appear the keyboard.
Changes proposed in this pull request:
Fixes: #1049
Edit: Tested that it still works on an older Android Device with Oero (Huawei) and is still working on iOS (iPhone X, iPhone 5). If needed I can also check Kitkat (4.4) and Android 5 or 6.
Edit 2:
@adamdbradley Had you something in your mind by using the preventDefault method? Could it break something? Should I test something? Can I somehow help you?