Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix detect ipad #1111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix detect ipad #1111

wants to merge 1 commit into from

Conversation

osben
Copy link

@osben osben commented Jun 18, 2020

after pull #1110

Short description of what this resolves:

Changes proposed in this pull request:

Fixes: #

@andmar8
Copy link

andmar8 commented Jul 14, 2020

I found 1110 and 1111 need a slight adjustment to make android v6 work

I managed to tsc the ionic-v3 codebase with [email protected], after using the new platform-registry and platform-utils you will get errors in android 6 claiming that lines in vendor.js don't know what "=>" and ")" is. For some reason it's not transpiling the fat arrows into functions in the js. I just changed the typescript function calls to normal js functions, that works fine with android 6....

platform-registry.ts lines 194, 199, 204 from "plt.zone.run(() => {" to "plt.zone.run(function(){"
platform-util.ts line 34 from "const isMobile = (win: Window) => matchMedia(win, '(any-pointer:coarse)');" to "const isMobile = function(win: Window){return matchMedia(win, '(any-pointer:coarse)');};"

This could well be I'm using the wrong tsc version to compile, but 3.7.x and 3.8.3 didn't work for me... in fact 3.6.2 needed some tweak to get it to build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants